add check for shared volumes in getVolumeStats #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dahuang <[email protected]>
adityadani
approved these changes
Feb 20, 2024
| @@ -365,7 +365,8 @@ func (s *OsdCsiServer) NodeGetVolumeStats(ctx context.Context, req *csi.NodeGetV | |||
|
|
|||
| var attachPathMatch bool | |||
There was a problem hiding this comment.
In general, I don't understand the reason for this path match check. Regardless of the attachPath we can always return the volume usage for every volume. The attach path does not dictate the volume usage.
dahuang-purestorage
force-pushed
the
PWX-35351-fix-nodegetvolume-shared-vol
branch
from
b4ed691 to
b015850
Compare
|
chatted with @adityadani offline. Removing the attach_path check will break how CSI sanity, so let's keep the attach_path validation. |
pureneelesh
approved these changes
Feb 21, 2024
Signed-off-by: dahuang <[email protected]>
dahuang-purestorage
added a commit
that referenced
this pull request
Feb 21, 2024
* add check for shared volumes in getVolumeStats Adds check for shared v4 volumes that have a different attach path than the assumed CSI volume path. JIRA: PWX-35351 Signed-off-by: dahuang <[email protected]>
dahuang-purestorage
added a commit
that referenced
this pull request
Feb 21, 2024
Signed-off-by: dahuang <[email protected]>
dahuang-purestorage
added a commit
that referenced
this pull request
Feb 21, 2024
* add check for shared volumes in getVolumeStats (#2419) Adds check for shared v4 volumes that have a different attach path than the assumed CSI volume path. JIRA: PWX-35351 Signed-off-by: dahuang <[email protected]>
cnbu-jenkins
pushed a commit
that referenced
this pull request
Feb 27, 2024
* add check for shared volumes in getVolumeStats Adds check for shared v4 volumes that have a different attach path than the assumed CSI volume path. JIRA: PWX-35351 Signed-off-by: dahuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds check for shared v4 volumes that have a different attach path than the assumed CSI volume path.
Which issue(s) this PR fixes (optional)
PWX-35351
Testing Notes
With the fix, we are able to see Used Space on OCP: